pan3793 commented on code in PR #5898:
URL: https://github.com/apache/kyuubi/pull/5898#discussion_r1434670936
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -3258,6 +3258,14 @@ object KyuubiConf {
.booleanConf
.createWithDefault(true)
+ val ENGINE_SPARK_NOTEBOOK_MODE: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.spark.notebook.mode")
+ .doc("Enable this to support notebook well." +
+ " For python notebook, the `text/plain` wrapped output will be
returned.")
Review Comment:
from the logic of the code, maybe we can name it as
`kyuubi.engine.spark.output.mode` with options "auto" and "notebook".
cc @cfmcgrady do you have suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
