pan3793 commented on code in PR #5901:
URL: https://github.com/apache/kyuubi/pull/5901#discussion_r1434691965


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1516,6 +1516,22 @@ object KyuubiConf {
       .timeConf
       .createWithDefault(Duration.ofSeconds(10).toMillis)
 
+  object EngineOpenOnFailure extends Enumeration {
+    type EngineOpenOnFailure = Value
+    val RETRY, DEREGISTER_IMMEDIATELY, DEREGISTER_AFTER_RETRY = Value
+  }
+
+  val ENGINE_OPEN_ON_FAILURE: ConfigEntry[String] =
+    buildConf("kyuubi.session.engine.open.onFailure")
+      .doc("The behavior when opening engine failed. " +
+        "RETRY: retry to open engine for ENGINE_OPEN_MAX_ATTEMPTS times. " +
+        "DEREGISTER_IMMEDIATELY: deregister the session immediately. " +
+        "DEREGISTER_AFTER_RETRY: deregister the session after retry to open 
engine for " +
+        "ENGINE_OPEN_MAX_ATTEMPTS times.")

Review Comment:
   replace ENGINE_OPEN_MAX_ATTEMPTS with the conf key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to