pan3793 commented on code in PR #5921:
URL: https://github.com/apache/kyuubi/pull/5921#discussion_r1436288538
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -313,18 +313,25 @@ private[kyuubi] class EngineRef(
* @param discoveryClient the zookeeper client to get or create engine
instance
* @param hostPort the existing engine host and port
*/
- def deregister(discoveryClient: DiscoveryClient, hostPort: (String, Int)):
Unit =
+ def deregister(discoveryClient: DiscoveryClient, hostPort: (String, Int)):
(String, Boolean) =
Review Comment:
can we invert the order of return value? `(Boolean, String)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
