dnskr opened a new pull request, #5934:
URL: https://github.com/apache/kyuubi/pull/5934

   # :mag: Description
   ## Issue References ๐Ÿ”—
   
   The PR adds basic support for configuration files to be used by Apache Spark 
query engine.
   Relates to 
https://github.com/apache/kyuubi/issues/4629#issuecomment-1489570556.
   
   ## Describe Your Solution ๐Ÿ”ง
   
   The PR adds:
    -  Apache Spark related `ConfigMap` that has to be mounted to Kyuubi pods 
as files.
    - `KYUUBI_CONF_DIR` and `SPARK_CONF_DIR` environment variables.
   
   The `ConfigMap` change:
    - does not require Kyuubi pods to be restarted, because related files 
content has to be changed eventually.
    - does not affect already running Spark applications.
   
   ## Types of changes :bookmark:
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   
   ## Test Plan ๐Ÿงช
   
   #### Behavior Without This Pull Request :coffin:
   
   Users can configure default Spark properties with `volumes`, `volumeMounts` 
and other general chart properties.
   The approach causes Kyuubi pod restarts.
   
   #### Behavior With This Pull Request :tada:
   
   Users can configure default Spark properties with `sparkConf.sparkEnv`, 
`sparkConf.sparkDefaults`, `sparkConf.log4j2` and `sparkConf.metrics`.
   The approach does not require Kyuubi pod restarts.
   
   #### Related Unit Tests
   
   N/A
   
   ---
   
   # Checklist ๐Ÿ“
   <!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here 
to help! -->
   
   - [ ] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
   
   **Be nice. Be informative.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to