pan3793 commented on code in PR #5946:
URL: https://github.com/apache/kyuubi/pull/5946#discussion_r1451948271
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala:
##########
@@ -129,102 +158,199 @@ case class EnginePage(parent: EngineTab) extends
WebUIPage("") {
}
}
- /** Generate stats of statements for the engine */
- private def generateStatementStatsTable(request: HttpServletRequest):
Seq[Node] = {
-
- val numStatement = store.getStatementList.size
-
- val table =
- if (numStatement > 0) {
+ /** Generate stats of running statements for the engine */
+ private def generateStatementStatsTable(
+ request: HttpServletRequest,
+ running: Seq[SparkOperationEvent],
+ completed: Seq[SparkOperationEvent],
+ failed: Seq[SparkOperationEvent]): Seq[Node] = {
+
+ val content = mutable.ListBuffer[Node]()
+ if (running.nonEmpty) {
+ val sqlTableTag = "running"
+ val table =
+ statementStatsTable(request, sqlTableTag, parent, running)
+ content ++=
+ <span id="running" class="collapse-aggregated-runningSqlstat
collapse-table"
Review Comment:
should the element id be unique globally on the whole page? maybe
`running-sqlstat` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
