Yikf commented on code in PR #5936:
URL: https://github.com/apache/kyuubi/pull/5936#discussion_r1452004696


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/engine/deploy/yarn/EngineYarnModeSubmitter.scala:
##########
@@ -92,6 +94,28 @@ abstract class EngineYarnModeSubmitter extends Logging {
   def engineExtraJars(): Seq[File] = Seq.empty
 
   protected def submitApplication(): Unit = {
+    val user = kyuubiConf.getOption(KYUUBI_SESSION_USER_KEY)

Review Comment:
   The user retrieved in this context is identified as appUser, which is 
supplied via the ProcessBuilder using the --conf parameter. However, the naming 
of the configuration key associated with this user appears to be somewhat 
unclear. 
   
   Are you suggesting that the key name should be updated for clarity, or are 
you indicating that appUser does not represent the intended proxy user?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to