pan3793 opened a new pull request, #5977:
URL: https://github.com/apache/kyuubi/pull/5977
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link
create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes argument position on constructing Trino
ClientSession.
## Describe Your Solution ๐ง
Invert `properties` and `Collections.emptyMap()` to match the
`ClientSession` constructor signature.
```
public ClientSession(
URI server,
String principal,
Optional<String> user,
String source,
Optional<String> traceToken,
Set<String> clientTags,
String clientInfo,
String catalog,
String schema,
String path,
ZoneId timeZone,
Locale locale,
Map<String, String> resourceEstimates,
Map<String, String> properties,
Map<String, String> preparedStatements,
Map<String, ClientSelectedRole> roles,
Map<String, String> extraCredentials,
String transactionId,
Duration clientRequestTimeout,
boolean compressionDisabled)
```
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the
boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklist ๐
<!--- Go over all the following points, and put an `x` in all the boxes that
apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] This patch was not authored or co-authored using [Generative
Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
