turboFei commented on code in PR #5948:
URL: https://github.com/apache/kyuubi/pull/5948#discussion_r1453840293
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala:
##########
@@ -52,6 +53,7 @@ class KyuubiSyncThriftClient private (
@volatile private var _engineId: Option[String] = _
@volatile private var _engineUrl: Option[String] = _
@volatile private var _engineName: Option[String] = _
+ private[kyuubi] def engineHostPort: (String, Int) = hostPort
Review Comment:
not needed
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -337,6 +337,15 @@ private[kyuubi] class EngineRef(
}
}
+ def getServiceNodes(
Review Comment:
nodes to node
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -337,6 +337,15 @@ private[kyuubi] class EngineRef(
}
}
+ def getServiceNodes(
+ discoveryClient: DiscoveryClient,
+ hostPort: (String, Int)): Option[ServiceNodeInfo] = {
+ tryWithLock(discoveryClient) {
Review Comment:
lock is not needed
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala:
##########
@@ -42,6 +42,7 @@ import org.apache.kyuubi.util.{ThreadUtils, ThriftUtils}
import
org.apache.kyuubi.util.ThreadUtils.scheduleTolerableRunnableWithFixedDelay
class KyuubiSyncThriftClient private (
+ hostPort: (String, Int),
Review Comment:
val hostPort: (String, Int),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
