cxzl25 commented on code in PR #5986:
URL: https://github.com/apache/kyuubi/pull/5986#discussion_r1458308594
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -114,9 +112,14 @@ case class SparkSQLEngine(spark: SparkSession) extends
Serverable("SparkSQLEngin
exec,
Duration(60, TimeUnit.SECONDS))
})
- engineSavePath.foreach { p =>
- val path = new Path(p)
- path.getFileSystem(spark.sparkContext.hadoopConfiguration).delete(path,
true)
+ try {
+ val path = new Path(engineSavePath)
Review Comment:
> So if we use sessionManager conf to check it here, the engine result save
path might be leak.
Got it. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
