davidyuan1223 opened a new pull request, #6022: URL: https://github.com/apache/kyuubi/pull/6022
# :mag: Description This pr could support use jdbc mode to connect with redis, we can use the url like 'jdbc:redis://host:port' to connect redis server [This is a Draft pr, beacause there are some questions need resolve] 1. Redis differs from common JDBC drivers like MySQL and Phoenix. Therefore, some common JDBC driver test cases are not applicable to Redis. Which components of Redis do we need to test? 2. Should we add a test case for Redis cluster mode? ## Issue References ๐ This pull request fixes #5469 <!-- Append the issue number after #. If there is no issue for you to link create one or --> <!-- If there are no issues to link, please provide details here. --> ## Describe Your Solution ๐ง 1. Choose a redis-jdbc-driver for this component, currently, the redis jdbc driver is from https://github.com/eacdy/redis-jdbc 3. Add Redis Dialect 4. Write Redis Unit Test Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes :bookmark: <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan ๐งช #### Behavior Without This Pull Request :coffin: #### Behavior With This Pull Request :tada: #### Related Unit Tests org/apache/kyuubi/engine/jdbc/redis/RedisSessionSuite.scala org/apache/kyuubi/engine/jdbc/redis/RedisStatementSuite.scala --- # Checklist ๐ <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
