pan3793 opened a new pull request, #6036:
URL: https://github.com/apache/kyuubi/pull/6036

   # :mag: Description
   ## Issue References ๐Ÿ”—
   <!-- Append the issue number after #. If there is no issue for you to link 
create one or -->
   <!-- If there are no issues to link, please provide details here. -->
   
   I get reported by a user using Kyuubi JDBC driver 1.8.0 to access Spark 
Thrift Server 2.4 (with Hive 1.2.1) with get an error on opening the session 
even with `clientProtocol=7`
   
   ```
   org.apache.hive.service.cli.HiveSQLException: 
java.lang.IllegalArgumentException: hive configuration 
hive.server2.thrift.resultset.default.fetch.size does not exists.
           at 
org.apache.hive.service.cli.session.HiveSessionImpl.configureSession(HiveSessionImpl.java:220)
           at 
org.apache.hive.service.cli.session.HiveSessionImpl.open(HiveSessionImpl.java:154)
           at 
org.apache.hive.service.cli.session.SessionManager.openSession(SessionManager.java:258)
           ... 13 more
   ```
   
   ## Describe Your Solution ๐Ÿ”ง
   
   When `hive.conf.validation` is `true` (it also is the default value), an 
IllegalArgumentException will be thrown if the provided configurations start 
with `hive.` and can not be recognized by the server.
   
   One solution is to disable `hive.conf.validation` on the server side, but we 
can also address it by avoiding passing this configuration if we know that the 
server does not support it.
   
   HIVE-14901 (2.3.0, HIVE_CLI_SERVICE_PROTOCOL_V10) introduces 
`hive.server2.thrift.resultset.default.fetch.size`, so we can set this 
configuration only when protocol >= HIVE_CLI_SERVICE_PROTOCOL_V10
   
   ## Types of changes :bookmark:
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   
   ## Test Plan ๐Ÿงช
   
   TODO
   
   #### Behavior Without This Pull Request :coffin:
   
   
   #### Behavior With This Pull Request :tada:
   
   
   #### Related Unit Tests
   
   
   ---
   
   # Checklist ๐Ÿ“
   <!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here 
to help! -->
   
   - [x] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
   
   **Be nice. Be informative.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to