pan3793 opened a new pull request, #6058:
URL: https://github.com/apache/kyuubi/pull/6058

   # :mag: Description
   ## Issue References ๐Ÿ”—
   <!-- Append the issue number after #. If there is no issue for you to link 
create one or -->
   <!-- If there are no issues to link, please provide details here. -->
   
   This pull request aims to make the Jetty server stop timeout configurable.
   
   The RESTful frontend has been enabled by default since 1.8.0, while a 
side-effect is observed, the process shutdown is always blocked by the Jetty 
server until reaches the default 30s timeout.
   
   ## Describe Your Solution ๐Ÿ”ง
   
   Two configurations are introduced in this PR
   ```
   kyuubi.frontend.trino.jetty.stopTimeout=5s
   kyuubi.frontend.rest.jetty.stopTimeout=5s
   ```
   while the 5s is chosen as the default value according to 
https://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/tree/jetty-server/src/main/config/etc/jetty.xml?h=jetty-9.3.x#n124
   
   ## Types of changes :bookmark:
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   
   ## Test Plan ๐Ÿงช
   
   1. perform `bin/kyuubi run`
   2. press `ctrl + c` to shutdown the Kyuubi process
   
   #### Behavior Without This Pull Request :coffin:
   
   takes ~30s to complete the shutdown progress.
   
   #### Behavior With This Pull Request :tada:
   
   takes ~5s to complete the shutdown progress.
   
   ---
   
   # Checklist ๐Ÿ“
   <!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here 
to help! -->
   
   - [x] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
   
   **Be nice. Be informative.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to