pan3793 commented on code in PR #6042:
URL: https://github.com/apache/kyuubi/pull/6042#discussion_r1495985225
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -797,6 +797,14 @@ object KyuubiConf {
.checkValues(AuthTypes)
.createWithDefault(Seq(AuthTypes.NONE.toString))
+ val FRONTEND_REST_AUTHENTICATION_METHOD: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.frontend.rest.authentication")
+ .doc("A comma-separated list of rest protocol client authentication
types." +
+ " It fallback to `kyuubi.authentication` if not configure.")
+ .version("1.9.0")
+ .serverOnly
+ .fallbackConf(AUTHENTICATION_METHOD)
+
val AUTHENTICATION_CUSTOM_CLASS: OptionalConfigEntry[String] =
buildConf("kyuubi.authentication.custom.class")
Review Comment:
should we make it support isolated too?
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -797,6 +797,14 @@ object KyuubiConf {
.checkValues(AuthTypes)
.createWithDefault(Seq(AuthTypes.NONE.toString))
+ val FRONTEND_REST_AUTHENTICATION_METHOD: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.frontend.rest.authentication")
+ .doc("A comma-separated list of rest protocol client authentication
types." +
+ " It fallback to `kyuubi.authentication` if not configure.")
+ .version("1.9.0")
+ .serverOnly
+ .fallbackConf(AUTHENTICATION_METHOD)
+
val AUTHENTICATION_CUSTOM_CLASS: OptionalConfigEntry[String] =
buildConf("kyuubi.authentication.custom.class")
Review Comment:
should we make it isolated too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
