tigrulya-exe commented on code in PR #6104:
URL: https://github.com/apache/kyuubi/pull/6104#discussion_r1506161313
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/schema/SchemaHelper.scala:
##########
@@ -100,6 +100,12 @@ abstract class SchemaHelper {
case Types.DECIMAL =>
decimalToTTypeId
+ case Types.FLOAT =>
+ floatToTTypeId
+
+ case Types.BOOLEAN =>
+ booleanToTTypeId
Review Comment:
As far as I understand, other dialects don't use this types or use another
JDBC types for the same types from db (for instance,`Types.BIT` for db
`boolean`), so I suggest to left these changes in current PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
