cxzl25 commented on code in PR #6112:
URL: https://github.com/apache/kyuubi/pull/6112#discussion_r1506978815
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSessionImpl.scala:
##########
@@ -110,12 +113,28 @@ class SparkSessionImpl(
}
override def close(): Unit = {
+ info(s"sessionId=${sessionEvent.sessionId}, " +
+ s"sessionRunTime=${formatDurationVerbose(sessionRunTime.get())}, " +
+ s"sessionCpuTime=${formatDurationVerbose(sessionCpuTime.get() /
1000000)}")
sessionEvent.endTime = System.currentTimeMillis()
+ sessionEvent.sessionRunTime = sessionRunTime.get()
+ sessionEvent.sessionCpuTime = sessionCpuTime.get()
EventBus.post(sessionEvent)
super.close()
spark.sessionState.catalog.getTempViewNames().foreach(spark.catalog.uncacheTable)
sessionManager.operationManager.asInstanceOf[SparkSQLOperationManager].closeILoop(handle)
sessionManager.operationManager.asInstanceOf[SparkSQLOperationManager].closePythonProcess(
handle)
}
+
+ val sessionRunTime = new AtomicLong(0)
+ val sessionCpuTime = new AtomicLong(0)
Review Comment:
We can move the variable definition to Line 49.
```suggestion
private val sessionRunTime = new AtomicLong(0)
private val sessionCpuTime = new AtomicLong(0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
