pan3793 commented on code in PR #6127:
URL: https://github.com/apache/kyuubi/pull/6127#discussion_r1512052179
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -319,7 +320,7 @@ trait ProcBuilder {
protected def getEngineHome(shortName: String): String = {
val homeKey = s"${shortName.toUpperCase}_HOME"
// 1. get from env, e.g. SPARK_HOME, FLINK_HOME
- env.get(homeKey)
+ env.get(homeKey).filter(StringUtils.isNotBlank)
Review Comment:
there is a typo in L310, mind fixing it as well? "directly" => "directory"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
