pan3793 commented on code in PR #6148:
URL: https://github.com/apache/kyuubi/pull/6148#discussion_r1517356740
##########
externals/kyuubi-trino-engine/src/main/scala/org/apache/kyuubi/engine/trino/session/TrinoSessionImpl.scala:
##########
@@ -49,7 +49,11 @@ class TrinoSessionImpl(
sessionManager: SessionManager)
extends AbstractSession(protocol, user, password, ipAddress, conf,
sessionManager) {
- val sessionConf: KyuubiConf = sessionManager.getConf
+ val sessionConf: KyuubiConf = {
+ val engineConf = sessionManager.getConf
+ conf.foreach(kv => engineConf.set(kv._1, kv._2))
Review Comment:
@cxzl25 seems we lack a pre-assembled session conf in AbstractSession, we
need some major refactor to simplify the current conf evaluation, I roughly
remember you have raised a similar idea previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
