pan3793 commented on code in PR #6207:
URL: https://github.com/apache/kyuubi/pull/6207#discussion_r1538506205
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/SchemaHelper.scala:
##########
@@ -65,7 +66,7 @@ object SchemaHelper {
case _: ArrayType => TTypeId.ARRAY_TYPE
case _: MapType => TTypeId.MAP_TYPE
case _: StructType => TTypeId.STRUCT_TYPE
- // TODO: it is private now, case udt: UserDefinedType =>
TTypeId.USER_DEFINED_TYPE
+ case _ if SparkDataTypeHelper.isUserDefinedType(typ) =>
TTypeId.USER_DEFINED_TYPE
Review Comment:
We are likely to drop support for 3.1 soon, then we can simplify the code
```suggestion
// SPARK-7768(fixed in 3.2.0) promoted UserDefinedType to DeveloperApi
case _ if SparkDataTypeHelper.isUserDefinedType(typ) =>
TTypeId.USER_DEFINED_TYPE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
