pan3793 commented on code in PR #6260:
URL: https://github.com/apache/kyuubi/pull/6260#discussion_r1554819730
##########
extensions/spark/kyuubi-extension-spark-3-4/src/main/scala/org/apache/kyuubi/sql/InsertShuffleNodeBeforeJoin.scala:
##########
@@ -49,7 +49,7 @@ object InsertShuffleNodeBeforeJoin extends Rule[SparkPlan] {
}
}
- // Since spark 3.3, insertShuffleBeforeJoin shouldn't be applied if join is
skewed.
+ // SPARK-33832 (Spark 3.3) already handles skew join cases
Review Comment:
yes, the comment is incorrect then. but seems SPARK-46170 recovers the skew
join cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
