Yikf commented on code in PR #6233:
URL: https://github.com/apache/kyuubi/pull/6233#discussion_r1554946099
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/SparkRangerAdminPlugin.scala:
##########
@@ -78,6 +78,10 @@ object SparkRangerAdminPlugin extends
RangerBasePlugin("spark", "sparkSql")
if (plugin != null) {
LOG.info(s"clean up ranger plugin, appId: ${plugin.getAppId}")
plugin.cleanup()
+ val auditProviderFactory = plugin.getAuditProviderFactory
+ if (auditProviderFactory != null) {
Review Comment:
LGTM overall excpet a minor comment.
AFAIK, `auditProviderFactory ` should not be null, maybe we can simplify it
to `plugin.getAuditProviderFactory.shutdown()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
