pan3793 commented on code in PR #6262:
URL: https://github.com/apache/kyuubi/pull/6262#discussion_r1558943273


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -594,6 +594,14 @@ abstract class TFrontendService(name: String)
     resp
   }
 
+  override def UploadData(req: TUploadDataReq): TUploadDataResp = {
+    throw new UnsupportedOperationException("Method UploadData has not been 
implemented.")
+  }
+
+  override def DownloadData(req: TDownloadDataReq): TDownloadDataResp = {
+    throw new UnsupportedOperationException("Method DownloadData has not been 
implemented.")

Review Comment:
   > On second thought, we can use TDownloadDataResp with the error status 
directly, just like CancelDelegationToken
   
   this approach is not applicable, because the resp has no `status` field, 
thus we can not mark the response as failed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to