cxzl25 commented on code in PR #5662:
URL: https://github.com/apache/kyuubi/pull/5662#discussion_r1582079328
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/EngineServiceDiscovery.scala:
##########
@@ -33,6 +34,10 @@ class EngineServiceDiscovery(
override def stop(): Unit = synchronized {
if (!isServerLost.get()) {
discoveryClient.deregisterService()
+ val path = s"/metrics${conf.get(HA_NAMESPACE)}"
Review Comment:
The code appears to concat this path multiple times. I suggest using a
method to call.
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/EngineServiceDiscovery.scala:
##########
@@ -33,6 +34,10 @@ class EngineServiceDiscovery(
override def stop(): Unit = synchronized {
if (!isServerLost.get()) {
discoveryClient.deregisterService()
+ val path = s"/metrics${conf.get(HA_NAMESPACE)}"
Review Comment:
The code appears to concat this path multiple times. I suggest using a
method to call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
