pan3793 commented on code in PR #6408:
URL: https://github.com/apache/kyuubi/pull/6408#discussion_r1609622722
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -797,8 +797,8 @@ private void openSession() throws SQLException {
if (launchEngineOpHandleGuid != null && launchEngineOpHandleSecret !=
null) {
try {
- byte[] guidBytes =
Base64.getMimeDecoder().decode(launchEngineOpHandleGuid);
- byte[] secretBytes =
Base64.getMimeDecoder().decode(launchEngineOpHandleSecret);
+ byte[] guidBytes =
Base64.getUrlDecoder().decode(launchEngineOpHandleGuid);
Review Comment:
I read the RFC4648 and RFC2045, as the length won't exceeds
`MIMELINEMAX=76`, `Encoder.getDecoder` should be fine here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
