pan3793 commented on code in PR #6458:
URL: https://github.com/apache/kyuubi/pull/6458#discussion_r1630956877
##########
.github/workflows/dep.yml:
##########
@@ -48,27 +48,15 @@ jobs:
check-latest: false
- name: Setup Maven
uses: ./.github/actions/setup-maven
- - name: Check kyuubi modules available
- id: modules-check
- run: >-
- build/mvn dependency:resolve validate
- -DincludeGroupIds="org.apache.kyuubi" -DincludeScope="compile"
- -Pfast -Denforcer.skip=false
- -pl kyuubi-ctl,kyuubi-server,kyuubi-assembly -am
- continue-on-error: true
- - name: build
+ - name: Install modules
env:
- MAVEN_OPTS: -Dorg.slf4j.simpleLogger.defaultLogLevel=error
- if: steps.modules-check.conclusion == 'success' &&
steps.modules-check.outcome == 'failure'
- run: >-
- build/mvn clean install
- -Pflink-provided,spark-provided,hive-provided
- -Dmaven.javadoc.skip=true
- -Drat.skip=true
- -Dscalastyle.skip=true
- -Dspotless.check.skip
- -DskipTests
- -pl kyuubi-ctl,kyuubi-server,kyuubi-assembly -am
+ MAVEN_ARGS: -Dorg.slf4j.simpleLogger.defaultLogLevel=error
Review Comment:
I suppose it should be MAVEN_ARGS, though it does not work before Maven 3.9
https://maven.apache.org/configure.html#maven_args-environment-variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
