pan3793 commented on code in PR #6383:
URL: https://github.com/apache/kyuubi/pull/6383#discussion_r1635777076


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -213,6 +254,32 @@ class FlinkProcessBuilder(
     }
   }
 
+  @volatile private var tokenTempDir: java.nio.file.Path = _
+  private def generateTokenFile(): Option[(String, String)] = {
+    // We disabled `hadoopfs` token service, which may cause yarn client to 
miss hdfs token.
+    // So we generate a hadoop token file to pass kyuubi engine tokens to 
submit process.
+    // TODO: Removed this after FLINK-35525, delegation tokens will be passed 
by `kyuubi` provider
+    conf.getOption(KYUUBI_ENGINE_CREDENTIALS_KEY).map { encodedCredentials =>
+      val credentials = KyuubiHadoopUtils.decodeCredentials(encodedCredentials)
+      tokenTempDir = Utils.createTempDir()

Review Comment:
   In Spark, `spark-submit` takes responsibility for cleaning the local staging 
dir on exiting. Does `flink` have a similar mechanism?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to