pan3793 commented on code in PR #6482:
URL: https://github.com/apache/kyuubi/pull/6482#discussion_r1644476123
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2761,6 +2761,14 @@ object KyuubiConf {
.version("1.10.0")
.fallbackConf(OPERATION_INCREMENTAL_COLLECT)
+ val ENGINE_SPARK_OPERATION_INCREMENTAL_COLLECT_SKIP_CANCEL_GROUP:
ConfigEntry[Boolean] =
+
buildConf("kyuubi.engine.spark.operation.incremental.collect.skip.cancel.group")
+ .doc("When true, the job group cancellation in executeStatement method "
+
+ "will be skipped on incremental collect mode")
Review Comment:
rather than repeating information that is easily inferred from the
configuration name, the documentation should be enriched to explain why should
this configuration be introduced and when should it be adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
