zcx513566 commented on PR #6526: URL: https://github.com/apache/kyuubi/pull/6526#issuecomment-2213802735
> @zcx513566 with an additional look at this issue and the [upstream change](https://github.com/apache/hive/commit/425e1ff7c054f87c4db87e77d004282d529599ae), I think the fix is invalid. And the UT you added is invalid too, it also passes without this patch. First the url should not remove comments. it also passes without this patch is because the UT only check sql content，not verified url. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
