turboFei commented on code in PR #6335:
URL: https://github.com/apache/kyuubi/pull/6335#discussion_r1683709269


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala:
##########
@@ -314,7 +317,9 @@ class KyuubiSessionManager private (name: String) extends 
SessionManager(name) {
           metadata.className,
           metadata.requestArgs,
           Some(metadata),
-          fromRecovery = true)
+          fromRecovery = true,
+          // todo: subResources
+          subResources = Map.empty[String, String])

Review Comment:
   seems all the uploaded sub resources are used by batch config,
   
   can we add a reserved key into batch conf?
   
   And get the uploaded files list(to cleanup) from batch conf when batch got 
recovered.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to