bowenliang123 commented on PR #6364: URL: https://github.com/apache/kyuubi/pull/6364#issuecomment-2257534401
Yes, the main concern comes to the benefit with mordernizing the Zinc version. Since last review, the Zinc has been bumped from 1.9.x to 1.10.x used with in the maven plugin. Zinc 1.10 brings the new analysis format for faster speed in reading and writing, see benchmark in https://github.com/sbt/zinc/pull/1350 . The compilation warning ( https://github.com/apache/kyuubi/pull/6364#issuecomment-2099631757 ) still occurs when compiling on JDK 8 + Scala 2.13, but it's not a blocker issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org