pan3793 commented on code in PR #6335:
URL: https://github.com/apache/kyuubi/pull/6335#discussion_r1704079340


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -401,6 +402,17 @@ class BatchJobSubmission(
         case e: Throwable => error(s"Error deleting the uploaded resource: 
$resource", e)
       }
     }
+
+    if (session.isExtraResourcesUploaded) {
+      // cleanup extra resources
+      extraResources.values.foreach { extraResource =>

Review Comment:
   +1 for this idea. We can upload all resources into `$BASE_DIR/<session_id>/` 
and clean the folder recursively, then we don't need to track the whole 
resource file list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to