wForget commented on code in PR #6585:
URL: https://github.com/apache/kyuubi/pull/6585#discussion_r1708654096
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/plugin/PluginLoaderSuite.scala:
##########
@@ -67,6 +67,19 @@ class PluginLoaderSuite extends KyuubiFunSuite {
assert(clusterAConfFromCache.get("kyuubi.ha.namespace") == "kyuubi-ns-a")
assert(clusterAConfFromCache.get("kyuubi.zk.ha.namespace") == null)
assert(clusterAConfFromCache.size() == 5)
+
+ conf.set(KyuubiConf.SESSION_CONF_PROFILE, Seq("cluster-a", "cluster-b"))
+ val clusterABConf =
Review Comment:
This case does not seem to reflect the scenario of multiple profiles.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/FileSessionConfAdvisor.scala:
##########
@@ -51,15 +51,18 @@ object FileSessionConfAdvisor extends Logging {
reloadInterval,
TimeUnit.MILLISECONDS)
.build(new CacheLoader[String, JMap[String, String]] {
- override def load(profile: String): JMap[String, String] = {
- val propsFile =
Utils.getPropertiesFile(s"kyuubi-session-$profile.conf")
- propsFile match {
- case None =>
- error("File not found: $KYUUBI_CONF_DIR/" +
s"kyuubi-session-$profile.conf")
- Collections.emptyMap()
- case Some(_) =>
- Utils.getPropertiesFromFile(propsFile).asJava
+ override def load(profiles: String): JMap[String, String] = {
Review Comment:
Should the key of sessionConfCache be one profile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
