pan3793 commented on code in PR #6597:
URL: https://github.com/apache/kyuubi/pull/6597#discussion_r1710631410
##########
externals/kyuubi-flink-sql-engine/pom.xml:
##########
@@ -30,6 +30,12 @@
<name>Kyuubi Project Engine Flink SQL</name>
<url>https://kyuubi.apache.org/</url>
+ <!-- Keep Flink Engine with Scala-2.12. -->
Review Comment:
I know that, currently, the whole Kyuubi project can be compiled with Scala
2.13 except for the Flink engine, while considering that the official Kyuubi
releases always use Scala 2.12, we don't need to make such changes.
Please revert Flink engine Scala version related changes.
In summary, what we need to do are:
1. upgrade Scala 2.13.11 in another PR ahead
2. just like what you do in https://github.com/apache/kyuubi/pull/6306, tune
the root `pom.xml` and add profile `java-21`
3. enable Java 21 test on CI with Spark 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
