turboFei commented on code in PR #6608:
URL: https://github.com/apache/kyuubi/pull/6608#discussion_r1715626758
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -839,7 +845,8 @@ object KyuubiConf {
val AUTHENTICATION_CUSTOM_CLASS: OptionalConfigEntry[String] =
buildConf("kyuubi.authentication.custom.class")
.doc("User-defined authentication implementation of " +
-
"org.apache.kyuubi.service.authentication.PasswdAuthenticationProvider")
+ "org.apache.kyuubi.service.authentication.PasswdAuthenticationProvider
" +
+ "or
org.apache.kyuubi.service.authentication.TokenAuthenticationProvider")
Review Comment:
And for
`kyuubi.authentication.custom.basic.class`, it should fallback to
`AUTHENTICATION_CUSTOM_CLASS`
.fallbackConf(AUTHENTICATION_CUSTOM_CLASS)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
