wForget commented on code in PR #6578:
URL: https://github.com/apache/kyuubi/pull/6578#discussion_r1719266891
##########
extensions/spark/kyuubi-spark-sql-engine-plugin/src/main/java/org/apache/kyuubi/engine/spark/plugin/PlanOnlyExecutor.java:
##########
@@ -14,18 +14,13 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.kyuubi.engine.spark.plugin;
-import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan;
-import org.apache.spark.sql.execution.SparkPlan;
+import org.apache.spark.sql.SparkSession;
-public interface SparkPlans {
+public interface PlanOnlyExecutor {
- LogicalPlan parsedPlan();
- LogicalPlan analyzedPlan();
- LogicalPlan optimizedPlan();
- SparkPlan sparkPlan();
- SparkPlan executedPlan();
+ String mode();
Review Comment:
We will use SPI to load plugins, so we need to define a qualified name for
the plugin to distinguish them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
