wForget commented on code in PR #6627:
URL: https://github.com/apache/kyuubi/pull/6627#discussion_r1721159957
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/OperationManager.scala:
##########
@@ -36,7 +38,7 @@ import org.apache.kyuubi.shaded.hive.service.rpc.thrift._
*/
abstract class OperationManager(name: String) extends AbstractService(name) {
- final private val handleToOperation = new java.util.HashMap[OperationHandle,
Operation]()
+ final private val handleToOperation = new ConcurrentHashMap[OperationHandle,
Operation]()
Review Comment:
The method using `handleToOperation` has synchronized block, do we still
need this change?
https://github.com/apache/kyuubi/blob/0165d5e3a26cc8353a9f7135e8fa4a9c4ae99e78/kyuubi-common/src/main/scala/org/apache/kyuubi/operation/OperationManager.scala#L98-L101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
