pan3793 commented on PR #49: URL: https://github.com/apache/kyuubi-shaded/pull/49#issuecomment-2297848894
> Why do we need to copy Spark proto files ? Can not add related spark-connect dependencies ? @ulysses-you not like Hive, which provides a dedicated `hive-service-rpc` jar that only ships the generated vanilla thrift files, Spark ships the generated protobuf/gRPC files as part of `spark-connect-common_2.13` with Guava/Protobuf/gRPC class relocations. For Kyuubi Commom and Server module, we just want a clean RPC layer, so copying proto files and regenerating is the cheapest way IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
