bowenliang123 commented on code in PR #6629:
URL: https://github.com/apache/kyuubi/pull/6629#discussion_r1734149200
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -545,7 +545,7 @@ private[v1] class BatchesResource extends ApiRequestContext
with Logging {
resourceFileInputStream: InputStream,
resourceFileName: String,
formDataMultiPartOpt: Option[FormDataMultiPart]): Option[JPath] = {
- val uploadFileFolderPath = batchResourceUploadFolderPath(batchId)
+ val uploadFileFolderPath =
KyuubiApplicationManager.sessionUploadFolderPath(batchId)
Review Comment:
Hi @turboFei @pan3793 , as batch id is not the same as the session id, is it
a misuse here, uploaded files are put along with `batch id`, but the cleanup
method `BatchJobSubmission#cleanupUploadedResourceIfNeeded` cleans up the path
with `session id` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
