turboFei commented on code in PR #6648:
URL: https://github.com/apache/kyuubi/pull/6648#discussion_r1738012483
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
super.initialize(conf)
}
+ // same as KyuubiTBinaryFrontendService, to return launch engine op handle
Review Comment:
```
TFrontendService -> TBinaryFrontendService -> KyuubiTBinaryFrontendService
TFrontendService -> TBinaryFrontendService -> SparkTBinaryFrontendService
TFrontendService -> KyuubiTHttpFrontendService
```
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTHttpFrontendService.scala:
##########
@@ -221,6 +228,45 @@ final class KyuubiTHttpFrontendService(
super.initialize(conf)
}
+ // same as KyuubiTBinaryFrontendService, to return launch engine op handle
Review Comment:
```
TFrontendService -> TBinaryFrontendService -> KyuubiTBinaryFrontendService
TFrontendService -> TBinaryFrontendService -> SparkTBinaryFrontendService
TFrontendService -> KyuubiTHttpFrontendService
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
