bowenliang123 commented on code in PR #6685:
URL: https://github.com/apache/kyuubi/pull/6685#discussion_r1754831946
##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/PrometheusReporterService.scala:
##########
@@ -35,12 +36,21 @@ class PrometheusReporterService(registry: MetricRegistry)
// VisibleForTesting
private[metrics] var httpServer: Server = _
+ private[metrics] var connector: ServerConnector = _
@volatile protected var isStarted = false
override def initialize(conf: KyuubiConf): Unit = {
val port = conf.get(MetricsConf.METRICS_PROMETHEUS_PORT)
val contextPath = conf.get(MetricsConf.METRICS_PROMETHEUS_PATH)
- httpServer = new Server(port)
+ val sendServerVersion = conf.get(FRONTEND_JETTY_SEND_VERSION_ENABLED)
Review Comment:
```suggestion
val jettyVersionEnabled = conf.get(FRONTEND_JETTY_SEND_VERSION_ENABLED)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
