wForget commented on code in PR #6688:
URL: https://github.com/apache/kyuubi/pull/6688#discussion_r1764349280
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala:
##########
@@ -59,7 +59,7 @@ class PlanOnlyStatement(
override protected def resultSchema: StructType = {
if (result == null) {
new StructType().add("plan", "string")
- } else if (result.isEmpty) {
+ } else if (result.schema.isEmpty) {
Review Comment:
I think we don't need to add a flag to distinguish them, because we handle
all cases：
```
if (result == null) {
...
else if (result.schema.isEmpty) {
...
} else {
result.schema
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
