pan3793 commented on code in PR #6383: URL: https://github.com/apache/kyuubi/pull/6383#discussion_r1806549960
########## kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala: ########## @@ -59,14 +62,26 @@ class FlinkProcessBuilder( // flink.execution.target are required in Kyuubi conf currently val executionTarget: Option[String] = conf.getOption("flink.execution.target") + private lazy val proxyUserEnable: Boolean = { + doAsEnabled && conf.get(ENGINE_FLINK_DOAS_ENABLED) Review Comment: > ... it can only be enabled on Kerberized environment. I think the logic here should be ``` if (conf.get(ENGINE_FLINK_DOAS_ENABLED)) { if (!UserGroupInformation.isSecurityEnabled) { log warning message false } else { true } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org