wankunde commented on code in PR #6758:
URL: https://github.com/apache/kyuubi/pull/6758#discussion_r1807185479
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RuleAuthorization.scala:
##########
@@ -34,23 +35,22 @@ case class RuleAuthorization(spark: SparkSession) extends
Authorization(spark) {
val auditHandler = new SparkRangerAuditHandler
val ugi = getAuthzUgi(spark.sparkContext)
val (inputs, outputs, opType) = PrivilegesBuilder.build(plan, spark)
- val requests = new ArrayBuffer[AccessRequest]()
+ var requests = new HashMap[(AccessResource, AccessType), AccessRequest]()
Review Comment:
1. Change to `mutable.HashMap`
2. Added some comments
3. I'm not sure if `immutable.Map.newBuilder` is better than
`mutable.HashMap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
