wForget commented on code in PR #6793: URL: https://github.com/apache/kyuubi/pull/6793#discussion_r1829085348
########## extensions/spark/kyuubi-extension-spark-3-5/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala: ########## @@ -332,19 +340,20 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel assert(df1.queryExecution.analyzed.isInstanceOf[InsertIntoHadoopFsRelationCommand]) checkSort(df1.queryExecution.analyzed.children.head) - withListener( - s""" - |CREATE TABLE zorder_t4 USING PARQUET - |TBLPROPERTIES ( - | 'kyuubi.zorder.enabled' = '$enabled', - | 'kyuubi.zorder.cols' = '$cols') - | - |SELECT $repartition * FROM - |VALUES(1,'a',2,4D),(2,'b',3,6D) AS t(c1 ,c2 , c3, c4) - |""".stripMargin) { write => - assert(write.isInstanceOf[InsertIntoHadoopFsRelationCommand]) - checkSort(write.query) - } + // TODO: CreateDataSourceTableAsSelectCommand is not supported Review Comment: `catalogTable` is empty https://github.com/apache/kyuubi/blob/master/extensions/spark/kyuubi-extension-spark-3-5/src/main/scala/org/apache/kyuubi/sql/zorder/InsertZorderBeforeWriting.scala#L151C40-L151C68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org