pan3793 commented on code in PR #6829:
URL: https://github.com/apache/kyuubi/pull/6829#discussion_r1866233445
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala:
##########
@@ -257,14 +257,15 @@ class JDBCMetadataStore(conf: KyuubiConf) extends
MetadataStore with Logging {
filter: MetadataFilter,
from: Int,
size: Int,
- desc: Boolean = false): Seq[Metadata] = {
+ desc: Boolean = false,
+ orderByKeyId: Boolean = true): Seq[Metadata] = {
Review Comment:
the parameters are evolving to Spark's `SortOrder`
```
case class SortOrder(
child: Expression,
direction: SortDirection,
nullOrdering: NullOrdering,
sameOrderExpressions: Seq[Expression])
```
how about using some SQL terminologies to redesign the method's signature?
```
override def getMetadataList(
filter: MetadataFilter,
offset: Int,
limit: Int,
orderBy: Option[String],
direction: String = "ASC"): Seq[Metadata]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
