pan3793 commented on code in PR #6839:
URL: https://github.com/apache/kyuubi/pull/6839#discussion_r1870694191


##########
charts/kyuubi/values.yaml:
##########
@@ -289,6 +289,8 @@ metrics:
     enabled: false
     # List of service endpoints serving metrics to be scraped by Prometheus, 
see Prometheus Operator docs for more details
     endpoints: []
+    # Example for endpoints of services to be monitored
+    # - port: prometheus

Review Comment:
   please also include the key itself, to avoid ambiguous indention, you can 
refer to the `resources: {}`'s example



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to