pan3793 commented on code in PR #6864:
URL: https://github.com/apache/kyuubi/pull/6864#discussion_r1897191016
##########
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/MetricsConf.scala:
##########
@@ -80,6 +80,13 @@ object MetricsConf {
.checkValue(path => path.startsWith("/"), "Context path must start with
'/'")
.createWithDefault("/metrics")
+ val METRICS_PROMETHEUS_METRICS_INSTANCE_ENABLED: ConfigEntry[Boolean] =
+ buildConf("kyuubi.metrics.prometheus.metrics.instance.enabled")
Review Comment:
maybe
```suggestion
buildConf("kyuubi.metrics.prometheus.labels.instance.enabled")
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
