turboFei commented on code in PR #6867:
URL: https://github.com/apache/kyuubi/pull/6867#discussion_r1897528085
##########
grafana/dashboard-template.json:
##########
@@ -684,27 +718,27 @@
{
"datasource": "${DS_PROMETHEUS}",
"editorMode": "code",
- "expr":
"kyuubi_memory_usage_pools_PS_Eden_Space_used{instance=~\"$instance\",job=~\"$job\"}",
+ "expr":
"kyuubi_memory_usage_pools_PS_Eden_Space_used{instance=~\"$instance\",$baseFilter}",
"hide": false,
- "legendFormat": "Eden Space Used",
+ "legendFormat": "${baseLegend} Eden Space Used",
"range": true,
"refId": "B"
},
{
"datasource": "${DS_PROMETHEUS}",
"editorMode": "code",
- "expr": "sum(kyuubi_memory_usage_pools_Par_Eden_Space_committed)",
+ "expr":
"kyuubi_memory_usage_pools_Par_Eden_Space_committed{instance=~\"$instance\",$baseFilter}",
"hide": false,
- "legendFormat": "Eden Space Committed",
+ "legendFormat": "${baseLegend} Eden Space Committed",
"range": true,
"refId": "A"
},
{
"datasource": "${DS_PROMETHEUS}",
"editorMode": "code",
- "expr": "sum(kyuubi_memory_usage_pools_Par_Eden_Space_max)",
Review Comment:
I think only reserve the Memery Usage + GC count is enough.
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
