Whojohn commented on PR #6879: URL: https://github.com/apache/kyuubi/pull/6879#issuecomment-2574302907
> the Kyuubi BeeLine is derived from Hive BeeLine(which is derived from SQLLine), does upstream BeeLine/SQLLine have similar functionalities? SQLLine combine with flink jdbc without those problem.(BeeLine not test yet.) > SQLLine without those problem because cancel is work. The fix way i try as fllow: 1. Fix cancel problem When pressing Ctrl-C, Beeline calls statement.cancel. However, the cancelOperation method in AbstractOperation checks the state in the cleanup method, causing the cancel operation to be ignored if the state is FINISHED. This issue is due to kyuubi Flink's state being FINISHED, which is not allowed in the current state check. To fix this problem, it seems that the cancel operation does not finish the Flink fetch, causing Beeline to continue calling result.next. The more I try to fix it, the more I find it breaks through too many mechanisms. 2. Fix this in BufferedRows as this pr done. (Because from now beeline depends on resultset.next but ignore cancel is calling.) By the way flink sql cancel stuck problem is more complex. Those i fix just consider data keep coming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
