bowenliang123 opened a new pull request, #6674: URL: https://github.com/apache/kyuubi/pull/6674
# :mag: Description ## Issue References ๐ <!-- Append the issue number after #. If there is no issue for you to link create one or --> <!-- If there are no issues to link, please provide details here. --> This pull request fixes # ## Describe Your Solution ๐ง Without this PR: - use and conform Scalafmt 3.7.x - forcing all the imports from the same parent package, which is even violation the max length of the line With this PR: - use and conform Scalafmt 3.8.x - Scalafmt 3.8.2 changes the binpack style: https://github.com/scalameta/scalafmt/releases/tag/v3.8.2 - change to `importSelectors=binpack`, wrapping the imports in `{}` while satisfying the the max length of the line `importSelectors=binpack` in Scalafmt 3.8: Forcing `{}` wrapper in extra line ``` import abc.def.xyz{ ..., ... , ..., ..., ... , ..., ..., ... , ..., ..., ... , ..., } ``` `importSelectors= singleLine` in Scalafmt 3.8: Forcing extra line break before last parent package name. (which is also disorder the dep groups and IDE display) ``` import abc.def .xyz.{ ..., ... , ..., ..., ... , ..., ..., ... , ..., ..., ...} ``` ## Types of changes :bookmark: <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan ๐งช #### Behavior Without This Pull Request :coffin: #### Behavior With This Pull Request :tada: #### Related Unit Tests --- # Checklist ๐ <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
