wForget commented on code in PR #7013:
URL: https://github.com/apache/kyuubi/pull/7013#discussion_r2032278127
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -82,6 +83,14 @@ private[kyuubi] class EngineRef(
private val enginePoolSelectPolicy: String =
conf.get(ENGINE_POOL_SELECT_POLICY)
+ private lazy val localHostAddr =
JavaUtils.findLocalInetAddress.getHostAddress
Review Comment:
```
private lazy val localHostAddr = {
val host = JavaUtils.findLocalInetAddress.getHostAddress
if (StringUtils.isBlank(host)) {
throw KyuubiSQLException(
s"Local host address can not be empty if ShareLevel set to
SERVER_LOCAL")
}
host
}
```
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -147,6 +157,9 @@ private[kyuubi] class EngineRef(
* /`serverSpace_version_USER_engineType`/`user`[/`subdomain`]
* For `GROUP` share level:
* /`serverSpace_version_GROUP_engineType`/`primary group
name`[/`subdomain`]
+ * For `SERVER_LOCAL` share level:
+ * /`serverSpace_version_SERVER_LOCAL_engineType`
+ * /`kyuubi server user`/`hostAddress`[/`subdomain`]
Review Comment:
This seems to have an extra layer than the original, @pan3793 @yaooqinn is
this allowed?
Or do we add server host to subdomain? like:
```
/`serverSpace_version_SERVER_LOCAL_engineType`/`kyuubi server
user`/`hostAddress`[_`subdomain`]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
